-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percussion panel - implement keyboard navigation for toolbar and pad grid #25518
Percussion panel - implement keyboard navigation for toolbar and pad grid #25518
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
82801ca
to
61198de
Compare
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelToolBar.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelToolBar.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelPad.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelToolBar.qml
Outdated
Show resolved
Hide resolved
61198de
to
9e46bcf
Compare
9e46bcf
to
1fdd85c
Compare
1fdd85c
to
15c1561
Compare
I've tested the latest build. It works well, but I found the following issues:
The screen reader might say row and column numbers afterwards, which is fine. You can test with your built-in screen reader. |
Thanks for this @shoogle! I'll be addressing some of these points in upcoming "refinements PRs"...
I don't see any of these as blockers so I'm going to go ahead and merge - I'll coordinate privately on some of the points I've mentioned above. Cheers! |
This PR lays the groundwork for keyboard navigation in the percussion panel. A handful of to-dos remain for future percussion panel PRs: