Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percussion panel - implement keyboard navigation for toolbar and pad grid #25518

Merged

Conversation

mathesoncalum
Copy link
Contributor

@mathesoncalum mathesoncalum commented Nov 14, 2024

This PR lays the groundwork for keyboard navigation in the percussion panel. A handful of to-dos remain for future percussion panel PRs:

  • Layout editing should be possible using the keyboard only
  • Escape button handling
  • Some subtle aspects of navigating up/down between rows are not to-spec yet.
  • Focus should move to the first pad in a new row when the "add row" button is triggered via keyboard.

@shoogle

This comment was marked as resolved.

@mathesoncalum mathesoncalum force-pushed the percussions_keyboard_navigation branch from 82801ca to 61198de Compare November 28, 2024 17:18
@mathesoncalum mathesoncalum force-pushed the percussions_keyboard_navigation branch from 61198de to 9e46bcf Compare December 3, 2024 12:15
@mathesoncalum mathesoncalum force-pushed the percussions_keyboard_navigation branch from 9e46bcf to 1fdd85c Compare December 3, 2024 15:25
@mathesoncalum mathesoncalum force-pushed the percussions_keyboard_navigation branch from 1fdd85c to 15c1561 Compare December 4, 2024 09:08
@shoogle
Copy link
Contributor

shoogle commented Dec 5, 2024

I've tested the latest build. It works well, but I found the following issues:

  1. The Percussion panel comes after the bottom bar (Workspace, etc.) in the Tab & F6 order.
    • Instead, the panel should go before the bottom bar in the Tab & F6 order.
  2. Pressing the "Write" button immediately puts you in note input mode.
    • Instead, it should remain in normal mode until the user presses one of the pads.
  3. After exchanging the position of two pads via keyboard, all pads gain a blue highlight and focus leaves the panel.
    • Instead, all pads should lose the highlight, and focus should remain on the destination pad.
  4. The "Reset layout" option does nothing.
  5. Ideally, the screen reader text for pads & footers should be like this:
Image image image
Pad speech: Bass Drum 1 pad button Side Stick pad button
Footer speech: Shortcut B; MIDI C2; Base Drum 1 footer button No shortcut; MIDI C sharp 2; Side Stick footer button

The screen reader might say row and column numbers afterwards, which is fine. You can test with your built-in screen reader.

@mathesoncalum
Copy link
Contributor Author

Thanks for this @shoogle! I'll be addressing some of these points in upcoming "refinements PRs"...

  1. We'll address this after the merging of For horizontal panels, show tab bar instead of title bar #22050 as this will change the navigation implementation slightly (see contentNavigationPanelOrderStart in that PR).

  2. I'll address this in an upcoming refinements PR

  3. I'm aware of the lost focus and I'll also be addressing this a refinements PR. As for the highlight behaviour, the spec suggests that the highlight remains after confirming the swap:

Screenshot 2024-12-05 at 12 48 41

  1. This was disabled after Percussion panel - save/load drum pad panel positions #25608 - some design considerations need to be made here before re-implementing.

  2. Looks good to me but the spec recommends something slightly different (namely including the row/column). Happy to include tweaks to this in a refinements PR.

Screenshot 2024-12-05 at 12 49 54

I don't see any of these as blockers so I'm going to go ahead and merge - I'll coordinate privately on some of the points I've mentioned above. Cheers!

@mathesoncalum mathesoncalum merged commit 8fa1eaa into musescore:master Dec 5, 2024
11 checks passed
@mathesoncalum mathesoncalum deleted the percussions_keyboard_navigation branch December 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants